387. First Unique Character in a String#14
Open
hiro111208 wants to merge 1 commit into
Open
Conversation
rimokem
reviewed
Apr 24, 2026
| chars.add(char) | ||
| unique_char_to_idx[char] = idx | ||
|
|
||
| if len(unique_char_to_idx) == 0: |
There was a problem hiding this comment.
辞書の空判定は、
if not unique_char_to_idx:とするのが良いかもしれません。
参考: https://google.github.io/styleguide/pyguide.html#2144-decision
nodchip
reviewed
Apr 25, 2026
| chars = set() | ||
| unique_char_to_idx = dict() | ||
|
|
||
| for idx, char in enumerate(s): |
There was a problem hiding this comment.
こちらのコメントをご参照ください。
hemispherium/LeetCode_Arai60#10 (comment)
| chars = set() | ||
| unique_char_to_idx = dict() | ||
|
|
||
| for idx, char in enumerate(s): |
There was a problem hiding this comment.
char は他の言語で予約語となっているため、避けたほうが無難かもしれません。 c・ch あたりが良いと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem: 387. First Unique Character in a String
Next problem: 104. Maximum Depth of Binary Tree