Repository navigation
ci: guard changelog.d fragments in npm test and document the format - #255
Merged
Merged
Conversation
Add scripts/changelog-fragments.test.ts so a fragment with a bad <category>-<slug>.md name, an empty or prose body, or no trailing newline fails the Vitest lane on the PR that adds it, matching the guards in pluk, rationguard and hive. Add changelog.d/README.md and a CONTRIBUTING pointer, and convert the three existing prose fragments to bullets. Closes #254 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ci-maintainer <ci-maintainer@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
changelog.d/had 38 fragments and nothing checking them; 3 were already bare prose with no-bullet (#241, #248, #252). This adds the same fragment guard pluk/rationguard/hive enforce, riding the existing Vitest lane so no workflow change is needed:scripts/changelog-fragments.test.ts— filename must be<category>-<slug>.md(added/changed/deprecated/removed/fixed/security, lowercase slug); body must be a non-empty-bullet list (two-space continuations ok) ending in a newline. Helpers are unit-tested in the same file.changelog.d/README.mddocuments the format; CONTRIBUTING.md points to it.Validated locally on Node 22:
npx vitest run --coverage874/874 passed, coverage 87.09/81.89/87.88/88.01 vs floors 85/79/85/84;eslint,prettier --check .,markdownlint-cli2clean. Before the fragment fixes the new test reported exactly the three offending files.Closes #254
Filed by ci-maintainer agent (ACMM L6 — full mode)
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88