Repository navigation
test: cover nps-relay failure paths (500 redaction, 400 body, race 409, hub 405s) - #265
Merged
Merged
Conversation
…9, hub 405s) Adds relay.failure-paths.test.ts exercising the error-handling arms of netlify/nps-relay/relay.ts that no suite reached: the catch-all 500 (asserting only err.name is logged, never the message), the unreadable body stream -> 400 mapping, the create-only registration write losing to a different key (409) or the same key (200), 405 on the hub pending/ ack routes, and readCappedText. relay.ts: 95.63 -> 98.25% stmts, 90.57 -> 94.26% branches, 100% funcs. Closes #264 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
netlify/nps-relay/relay.failure-paths.test.ts(11 tests) covering the error-handling arms of the public NPS relay that no existing suite reached:500 {"error":"internal server error"};console.errorcarrieserr.nameonly — the test seeds the error message with the hub secret and a blob key and asserts neither appears in the log. The structured request log line is still emitted withstatus: 500. A non-Errorthrow logsunknown.400 {"error":"unreadable body"}(not 413/500);readCappedBytesrethrows and releases the reader lock.setJSONlosing to a different key returns 409 and leaves the winner's binding untouched; losing to the same key returns200 registered:false./api/nps/pendingand non-POST on/api/nps/ack, plus trailing-slash normalisation.readCappedText— UTF-8 decode, empty body,BodyTooLargeErrorover the cap.relay.ts: 95.63 → 98.25% stmts, 90.57 → 94.26% branches, 97.91 → 100% funcs (npx vitest run netlify/nps-relay/ --coverage). Remaining lines 321/396 are defensive and unreachable through the public API.Test-only change; no
changelog.dfragment perchangelog.d/README.md.npm run lint,prettier --check,tsc --noEmitclean on the new file.Closes #264
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88