Repository navigation
test: cover language-switcher branches in useNavDropdowns - #266
Merged
hivecommons-hive[bot] merged 1 commit intoOct 7, 2026
Merged
Conversation
Adds 11 behavior tests for the language-switcher integration in useNavDropdowns: cancelling a pending nav-dropdown hide on switcher hover, hovering while the listbox is already visible, leaving without a listbox, close-lang-switcher without a visible listbox, listbox mouseenter/mouseleave wiring via MutationObserver (direct and nested added nodes), listbox removal while hovered, unrelated-node removal, and observer teardown on unmount. useNavDropdowns.ts: 91.0% -> 100% lines, 93.1% -> 100% functions, 73.9% -> 85.5% branches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hivecommons-hive
Bot
added
quality
kubestellar-prow
Bot
deleted the
quality/test-nav-lang-switcher-branches
branch
October 7, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
src/components/navbar/useNavDropdowns.tshad 14 uncovered lines, all in the language-switcher integration (.language-switcher-containerhover handling and theMutationObserverthat wires the portal-rendered[role="listbox"]). These paths drive real UI state (isDropdownOpen) and the switcher's open/close clicks, so a regression there would silently break hover-to-open on the navbar.This PR adds 11 behaviour tests to
src/__tests__/useNavDropdowns.test.tsxcovering:close-lang-switcherwhile hovered but no listbox visible (state cleared, no click), and when neither hovered nor visible (no-op)MutationObserverwiring of the listbox's ownmouseenter(cancels close) /mouseleave(schedules close), for both a directly-added listbox and one nested inside an added subtreeisDropdownOpendrops tofalse; removal of unrelated nodes is ignoredCoverage (
npx vitest run --coverage,coverage/lcov.info, HEAD5d49f94)useNavDropdowns.tsNo production code changed. Test-only, so no
changelog.dfragment perchangelog.d/README.md.npm run lint,prettier --check, andtsc --noEmitpass on the test file.Evidence note: this repository has only the vitest unit suite (no end-to-end suite is configured), so the gap above was covered by no automated test before this PR.
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88