Repository navigation
test: cover mdx-to-markdown block, fence and attribute edge cases - #274
Merged
hivecommons-hive[bot] merged 1 commit intoOct 8, 2026
Merged
Conversation
Adds scripts/mdx-to-markdown.edge-cases.test.ts exercising the converter paths that had no tests: unterminated and nested blocks, stray closing tags, fence-aware close detection (tilde fences, longer fences, fence lines with trailing text), dedent of blank/zero-indent bodies, attribute parsing fallbacks, YouTube/Step/AgentBlock rendering variants, CRLF and single-quoted frontmatter, and the siteBase/imagePrefix/rewriteImage options. mdx-to-markdown.ts: 93.1% stmts / 79.7% branches -> 100% / 99.2%. Closes #273 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubestellar-prow
Bot
deleted the
quality/test-mdx-to-markdown-edge-cases
branch
October 8, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
scripts/mdx-to-markdown.edge-cases.test.ts(29 tests) covering the converter paths that had no tests:<Step>depth tracking, closing tags inside fences ignored~~~fences, a 4-backtick fence not closed by~~~/```, fence lines with trailing text not treated as a close{false}, negative/decimal numbers,{"quoted"}unwrap, non-literal expression text?→&t=, missing/non-numericstart; Step heading-only / number-only; AgentBlock unknown-id capitalisation andAgentfallbackkey: valuelines, mismatched quotesdescriptionfallback, no title/description, trailing-slashsiteBase, customimagePrefix/rewriteImagewith image title, blank-line collapsing, inline-code protectionscripts/mdx-to-markdown.ts: 93.1% stmts / 79.7% branches → 100% / 99.2% (npx vitest run scripts/mdx-to-markdown --coverage). Full suite,eslint,prettier --checkandtsc --noEmitpass.No production code changed. The linked-image regex quirk noted in the issue is intentionally not asserted so it is not locked in.
Closes #273
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88