test: add static markup gate for ids, ARIA idrefs, img alt and script data-* hooks - #84
Merged
Merged
Conversation
… data-* hooks Adds scripts/page-markup.test.mjs, a zero-dependency gate over every committed non-redirect HTML page: ids are unique, ARIA idrefs and label[for] resolve, every img has alt, the root html element declares lang, role=tab/tabpanel carry their ARIA pair, and every [data-*] selector an inline script queries exists in the markup. Each rule has a fixture self-test. Picked up by the existing scripts/*.test.mjs glob in the links workflow test job; no workflow change. Closes #83 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
scripts/page-markup.test.mjs, a zero-dependency static gate over every committed non-redirect HTML page (index.html,stories/index.html). For each page it asserts:ids are unique (and non-empty)aria-controls,aria-labelledby,aria-describedby,aria-owns,aria-activedescendant) andlabel forresolves to anidon the same page — ids that appear only inside script text do not countimghas analtattributehtmlelement declareslangrole="tab"hasaria-controlsand everyrole="tabpanel"hasaria-labelledby[data-*]selector a page's inline scriptquerySelectors exists in the page's markup (CSS and script text do not count), so a dropped attribute can no longer make a carousel silentlyreturnearlyEach rule has fixture self-tests proving it both passes clean markup and fires on bad markup (10 fixture tests + 13 live-page tests + 1 hook sanity test). Mutation-checked against the real page: renaming one
aria-controlstarget and onedata-car-trackattribute each produce a single failing test naming the line/hook.The CI
testjob already runsnode --test scripts/*.test.mjs, so the new file is picked up with no workflow change. README "Checks" section updated.Verified locally:
node --test scripts/*.test.mjs→ 140 pass, 0 fail;scripts/check-links.sh→ 0 internal errors.Closes #83
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88