Skip to content

CCD-7726 - filter case roles creation and add tests - #2967

Open
markdathornehmcts wants to merge 11 commits into
masterfrom
CCD-7726
Open

CCD-7726 - filter case roles creation and add tests#2967
markdathornehmcts wants to merge 11 commits into
masterfrom
CCD-7726

Conversation

@markdathornehmcts

Copy link
Copy Markdown
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/CCD-7726

Change description

Make the contract explicit and more robust:

keep only active RoleType.ORGANISATION assignments for case creation;
additionally exclude any role assignment where attributes.caseId is present;
add tests proving that RoleType.CASE assignments and organisation assignments with a caseId cannot contribute to create access;
leave read/update/delete untouched because those flows need case-specific role assignments.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@paulridout paulridout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants