DTSCCI-6319 Updated RoleAssignmentService to return an empty list when CCD/RAS returns no role assignments - #3006
Open
matt-goodwin-solirius wants to merge 1 commit into
Open
DTSCCI-6319 Updated RoleAssignmentService to return an empty list when CCD/RAS returns no role assignments#3006matt-goodwin-solirius wants to merge 1 commit into
matt-goodwin-solirius wants to merge 1 commit into
Conversation
…n CCD/RAS returns no role assignments.This prevents the roles.stream() NullPointerException during grantAccessToCase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DTSCCI-6319
Change description
The functional test was failing on https://github.com/hmcts/cmc-citizen-frontend preview pipelines because claim creation triggered LINK_LETTER_HOLDER. CCD data-store queried role assignments for the new user and returned a response with no role list. RoleAssignmentService then called .stream() on the null list, causing a 500 response.
The claim-store wrapped this as:
Failed updating claim in CCD store on event LINK_LETTER_HOLDER
The claim therefore never reached OPEN, and the later DisputesAll request failed with 422: The case status did not qualify for the event.
This allows CCD data-store to continue granting case access when the user has no existing role assignments. The normal role-assignment path is unchanged.
This allows:
Does this PR introduce a breaking change? (check one with "x")