Skip to content

CIMD-3915 : remove wrong integration test #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SachinDangui merged 2 commits into from
Jun 20, 2026
Merged

CIMD-3915 : remove wrong integration test #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e457510
CIMD-3915 : remove wrong integration test
Jun 19, 2026
fc53da2
Merge branch 'team/CIMD-3915-verdict-object' into CIMD-3915-informant…
erolkurelihmcts Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions ...tion-test/src/test/java/uk/gov/moj/cpp/results/it/InformantRegisterDocumentRequestIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,33 +80,6 @@ public void shouldAddInformantRegisterRequestWithVerdictAndExposeItInProsecutorR
helper.verifyInformantRegisterIsNotified(prosecutionAuthorityId);
}

@Test
public void shouldRejectInformantRegisterWithVerdictCodeButNoVerdictDate() throws IOException {
// T071 / FR-004: verdict.json `dependencies` makes verdictCode and verdictDate co-dependent.
// A command carrying verdictCode without verdictDate is rejected by JSON-schema validation on the
// (async) command-handler side, so it is never recorded. Commands here are accepted onto the queue
// (202) and validated asynchronously, so the rejection is observed as the absence of a recorded
// register rather than a synchronous 4xx.
final UUID rejectedProsecutionAuthorityId = randomUUID();
final UUID hearingId = randomUUID();
final ZonedDateTime registerDate = now(UTC);
final ZonedDateTime hearingDate = now(UTC).minusHours(1);
final String prosecutionAuthorityCode = STRING.next();

final Response writeResponse = recordInformantRegister(rejectedProsecutionAuthorityId, prosecutionAuthorityCode, registerDate,
hearingId, hearingDate, "json/informant-register/results.add-informant-register-document-request-with-invalid-verdict.json");
assertThat(writeResponse.getStatusCode(), equalTo(SC_ACCEPTED));

// Sentinel: a valid command submitted after the rejected one. Once it is RECORDED the system has
// demonstrably processed informant-register commands, so the rejected command must remain absent.
final UUID sentinelProsecutionAuthorityId = randomUUID();
final Response sentinelResponse = recordInformantRegister(sentinelProsecutionAuthorityId, STRING.next(), now(UTC),
randomUUID(), now(UTC).minusHours(1), "json/informant-register/results.add-informant-register-document-request.json");
assertThat(sentinelResponse.getStatusCode(), equalTo(SC_ACCEPTED));

helper.verifyInformantRegisterRejectedNotRecorded(sentinelProsecutionAuthorityId, rejectedProsecutionAuthorityId);
}

@Test
public void shouldAddInformantRegisterRequestForGroupCases() throws IOException {
final UUID prosecutionAuthorityId = randomUUID();
Expand Down
Loading