CHD-3035 - fix AddCaseDocumentIT expecting caseId as the uploaded document id - #160
Merged
Merged
Conversation
…ument id The public case-document-uploaded event carries the caller's document reference as documentId; #158 accidentally changed the expectation to caseId, failing validation build 875649. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aykutdanisman
requested review from
erolkurelihmcts,
habibulrahaman and
tmckillop95
and removed request for
a team
September 28, 2026 17:33
|
|
jayenhc
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Validation build 875649 on
team/CHD-2786(after #158 merged) failed onAddCaseDocumentIT.shouldUploadCaseDocumentSuppliedByReferenceOnTheJsonBranch:179. #158 accidentally changed that assertion fromis(documentReference)tois(caseId).verifyCaseDocumentUploadedEventRaised()returns$.documentIdfrompublic.sjp.case-document-uploaded, which is the caller-supplied reference, so the test could never pass.Change
Restore the expectation to
documentReference. Test-only change, no production code.Verification
mvn -o -pl sjp-integration-test test-compile: compiles. The ITs need the full stack, so I didn't run them locally.PleadOnlineITwith "readyForDecision". Both failed the same way in the CHD-2830 - sjp changes for documentUri #156 validation run (863269), andPleadOnlineITalso failed on another team branch (875474). This PR doesn't address them.🤖 Generated with Claude Code