Repository navigation
test(replay): freeze the v3 candidates rewritten to expect().toBe() - #125
Merged
Merged
Conversation
Rewrites each assertSame(a, b) candidate of the frozen v3 corpus to expect(a).toBe(b) as designated v5 tests over the same worlds and policy, produced by assertledger@2.1.0. The corpus test re-derives the rewrite from the frozen v3 request and requires the same decision, gates and observation outcomes as the v3 manifest. E11 (#111) measured toBe against Object.is. Refs #84 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Freezes the candidates of
evidence-v3rewritten fromassertSame(a, b)to Bun's nativeexpect(a).toBe(b)(ADR 0004), as a new replay-corpus entrycandidates-v3-tobe:tests/replay-corpus/inputs/candidates-v3-tobe/(same worlds and policy as v3, one designated test per candidate);assertledger@2.1.0withbun-test-designated, decisionVERIFIED;corpus.jsonentry withrewriteOf: "evidence-v3", replayed by the current build like every other entry.tests/replay-corpus.test.tsgains arewritten v3 candidatessuite:assertSame→expect().toBe()rewrite;E11 (#111) established that
toBeaccepts exactly the pairsObject.isaccepts on Bun 1.4.2, which is what makes this rewrite verdict-preserving.Proof
Negative witnesses in a disposable worktree at
783df8e, each red onERR_ASSERTIONin the designated test, then green after restore:strong.test.ts:.toBe(→.toEqual(designates expect(a).toBe(b)…request.json: world 1 subject altereddesignates expect(a).toBe(b)…WEAK_ORACLE→ELIGIBLEreaches the verdicts…corpus.json:rewriteOfremovedrewrite every v3 candidate corpuspnpm check: 995 tests pass, 0 fail.inputs/candidates-v3-tobe/repository/package.jsonis{"type":"module"}, no scripts: no route change.Limits
Test plan
pnpm checkRefs #84
🤖 Generated with Claude Code