Repository navigation
fix(outpost mcp): refuse destination fields the type does not declare - #450
Merged
Merged
Conversation
The CLI rejects a destination config or credential key the type does not declare. outpost_destinations_write accepted one: an unknown config key was stored and an unknown credential was dropped, both reported as success. A misspelled optional field -- custom_header for custom_headers -- looked applied and never took effect. The tool called outposttypes.ApplyDefaultsForType but never checked keys against the schema. It now does, on create and update. Update takes no type, so it reads the destination's; if that read fails the update is sent anyway, since the API reports a missing destination better than a guess here would. Only unknown keys are checked. Required fields, allowed values and formats are already enforced by the API on both surfaces, and the CLI's messages for those are phrased as flags, which an agent cannot use. The new UnknownFields helper in outposttypes carries the one rule MCP needs, with the same nested-value deferral as the CLI. A schema that cannot be fetched does not block the request, matching the CLI. Tests: unknown config key on create, unknown credential on create, unknown config key on update -- each refused without reaching the API -- and declared fields passing through. Verified to fail without the fix, and against the live Outpost API: the misspelled key is refused, the valid create succeeds. Fixes #447 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012XtSQ2kfpcRXXqweskgXkH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #447.
outpost_destinations_writeaccepted config and credential keys the destination type does not declare. An unknown config key was stored and an unknown credential was dropped, both reported as success. The CLI has always rejected them.A misspelled optional field —
custom_headerforcustom_headers— looked applied and never took effect.Fix
configandcredentialskeys against the type schema. Update takes no type, so it reads the destination's; if that read fails, the update goes through and the API reports the problem.--configflags, which an agent cannot use. A newoutposttypes.UnknownFieldshelper carries the one rule, with the same nested-value deferral as the CLI.The error names the fields and the tool that lists the valid ones:
Tests
Found by the v3.0 Outpost end-to-end QA pass. Intended for v3.0.2.
🤖 Generated with Claude Code
https://claude.ai/code/session_012XtSQ2kfpcRXXqweskgXkH