Skip to content

fix(test): pin ClickHouse merges in the chlogstore dedup tests #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexluong wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(test): pin ClickHouse merges in the chlogstore dedup tests #1042

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96be56c
fix(test): pin ClickHouse merges in the chlogstore dedup tests
alexluong Aug 14, 2026
aa4be73
test(chlogstore): derive the stopped table from the log store itself
alexluong Aug 14, 2026
9ff659c
test(chlogstore): trim the stopMerges comments
alexluong Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions internal/logstore/chlogstore/chlogstore_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,28 @@ func setupClickHouseConnection(t *testing.T) clickhouse.DB {
return chDB
}

// stopMerges holds duplicate rows in place for tests that assert on them —
// ReplacingMergeTree collapses rows sharing the ORDER BY key on merge.
//
// The table must be qualified: bare SYSTEM STOP MERGES is server-wide, and every
// test shares one ClickHouse server.
func stopMerges(t *testing.T, chDB clickhouse.DB, table string) {
t.Helper()

ctx := context.Background()
var database string
require.NoError(t, chDB.QueryRow(ctx, "SELECT currentDatabase()").Scan(&database))

// SYSTEM STOP MERGES reports success for a table that does not exist.
var exists uint64
require.NoError(t, chDB.QueryRow(ctx,
"SELECT count() FROM system.tables WHERE database = ? AND name = ?",
database, table).Scan(&exists))
require.Equal(t, uint64(1), exists, "no table %s.%s to stop merges on", database, table)

require.NoError(t, chDB.Exec(ctx, "SYSTEM STOP MERGES "+database+"."+table))
}

func newHarness(_ context.Context, t *testing.T) (drivertest.Harness, error) {
t.Helper()

Expand Down Expand Up @@ -156,7 +178,12 @@ func TestEventDedup(t *testing.T) {
chDB := setupClickHouseConnection(t)
defer chDB.Close()

logStore := NewLogStore(chDB, "")
// Concrete type: the test needs the same table name the queries use.
logStore := NewLogStore(chDB, "").(*logStoreImpl)

// The injected duplicates below share (event_time, event_id) with the
// originals, so a merge would collapse the raw count from 9 to 3.
stopMerges(t, chDB, logStore.eventsTable)

tenantID := "dedup-tenant"
baseTime := time.Now().Truncate(time.Second)
Expand Down Expand Up @@ -285,6 +312,13 @@ func TestFetchAndDedupTruncation(t *testing.T) {
chDB := setupClickHouseConnection(t)
defer chDB.Close()

// Concrete type: the test needs the same table name the queries use.
logStore := NewLogStore(chDB, "").(*logStoreImpl)

// evt-trunc-a is inserted twice at one event_time; a merge would collapse it
// and the first batch would come back deduplicated, so no overshoot to catch.
stopMerges(t, chDB, logStore.eventsTable)

tenantID := "dedup-truncation"
baseTime := time.Now().Truncate(time.Second)

Expand All @@ -310,7 +344,7 @@ func TestFetchAndDedupTruncation(t *testing.T) {
Compare: "<",
SortDir: "desc",
}, func(qi pagination.QueryInput) (string, []any) {
return buildEventQuery("events", driver.ListEventRequest{
return buildEventQuery(logStore.eventsTable, driver.ListEventRequest{
TenantIDs: []string{tenantID},
TimeFilter: driver.TimeFilter{GTE: &startTime},
}, qi)
Expand Down
Loading