chore: remove unused aws-sdk-go v1 dependency - #1047
Open
alexluong wants to merge 1 commit into
Open
Conversation
alexluong
changed the title
alexbouchardd
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-sdk-gov1 is still in the module graph, but nothing uses it as an SDK. Three files import it for exactly one helper —aws.String()— and all three already use v2 clients for the actual AWS work:internal/util/awsutil/awsutil.gointernal/mqs/queue_awssqs.gointernal/destregistry/providers/destawssqs/destawssqs.goaws-sdk-go-v2/awsprovides the sameaws.String(), so the import swap is mechanical and v1 drops out ofgo.modandgo.sumentirely. One less SDK to keep patched, and no second AWS SDK version for readers to reason about.It also costs something at runtime, which is what made it noticeable: v1's
awspackage pulls inaws/endpointsthroughConfig.EndpointResolver, and that package'sinit()builds the full AWS region and service catalog into package-level maps.init()runs whether or not the package is used and the maps stay reachable for the process lifetime, so it is never collected — about 2.6 MiB of live heap on an idle process that may never touch AWS at all.go test -short ./...passes.🤖 Generated with Claude Code