feat: add knative resource defaults and nodepool

[patrickleet]

Summary:

• Add explicit resource requests/limits for Knative operator, Knative Serving, Knative Eventing, and NATS components.
• Align request values with current target-cluster Goldilocks/VPA recommendations where available.
• Add opt-in spec.nodePool support for hops-knative; default remains disabled.
• Cover resource defaults and nodepool placement in render tests and examples.

Verification:

• make test: 11/11 passed.
• hops config install --path xrs/stacks/k8s/knative --context colima: completed, package healthy.
• Colima KnativeStack/default pat-local: Synced=True Ready=True.
• Colima Helm Releases pat-local-knative-operator and pat-local-nats: observed current generation, Synced=True Ready=True, state=deployed.
• Target KnativeServing and KnativeEventing CRs: Ready=True.
• Target knative-operator/knative-operator: 1/1 ready, requests cpu=15m memory=100Mi, limits cpu=1 memory=512Mi.
• Target knative-operator/operator-webhook: 1/1 ready, requests cpu=15m memory=284Mi, limits cpu=500m memory=512Mi.
• Target knative-serving deployments: all 1/1 ready; managed components request cpu=15m memory=100Mi and limit memory=256Mi.
• Target knative-eventing deployments/statefulset: ready; eventing-controller requests cpu=15m memory=284Mi, eventing-webhook requests cpu=15m memory=309Mi, remaining managed components match Goldilocks-backed defaults.
• Target nats/pat-local-nats: 3/3 ready, nats requests cpu=11m memory=50Mi, limits cpu=500m memory=512Mi; reloader requests cpu=11m memory=50Mi; nats-box 1/1 ready with requests cpu=15m memory=100Mi.

NodePool note:

• pat-local does not currently set spec.nodePool, so no hops-knative NodePool exists or is active. The nodepool path is opt-in and covered by render tests.

[coderabbitai]

Warning

Review limit reached

@patrickleet, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 17 minutes and 34 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc04f414-57e2-4950-8319-269c274ccd70

📥 Commits

Reviewing files that changed from the base of the PR and between 164568b and 54a2176.

📒 Files selected for processing (7)

• Makefile
• apis/knativestacks/definition.yaml
• examples/knativestacks/nodepool.yaml
• functions/render/000-state-init.yaml.gotmpl
• functions/render/155-nodepool.yaml.gotmpl
• functions/render/210-knative-operator.yaml.gotmpl
• tests/test-knative/main.k

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/knative-resource-defaults-nodepool

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/knative-stack:pr-14-9c31160c15e51a63b1cc178e3e4ef58978f04b08

View Package