Generate non-finite float defaults as valid Python source - #212
Open
Sanjays2402 wants to merge 1 commit into
Open
Generate non-finite float defaults as valid Python source#212Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
A schema default of NaN or infinity was written into the generated
validation function with repr(), which produces the bare names `nan`,
`inf` and `-inf`. Those names do not exist in the generated module's
global state, so compiling such a schema produced a function that raised
`NameError: name 'nan' is not defined` as soon as the default was applied.
Added `repr_default()`, which renders non-finite floats as `float('nan')`
and recurses into lists, tuples and dicts so nested defaults are handled
too; everything else still goes through plain repr(). It is used for both
the default-assignment code and the `definition=` argument of the
generated exceptions, which had the same leak.
Fixes horejsek#101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
A schema
defaultof NaN or infinity was written into the generated validation function withrepr(), which emits the bare namesnan/inf/-inf. Those names don't exist in the generated module's globals, so compiling such a schema produced a function that raisedNameError: name 'nan' is not definedthe moment the default was applied.Added
repr_default(), which renders non-finite floats asfloat('nan')and recurses into lists/tuples/dicts for nested defaults; everything else still goes through plainrepr(). It's also used for thedefinition=argument of the generated exceptions, which had the same leak.Regression tests in
tests/test_default.pyfail withNameErroron master and pass with the fix; full suite is green (503 passed, 4 skipped).