Repository navigation
Close phase 8 and plan phases 9 to 11 - #27
Merged
Merged
Conversation
The roadmap closes phase 8 with PR #24 and adds three phases: faster evaluation, the ranking with episode chunks, and a large memory store. The later phases move to 12 to 15. plan.md holds the tasks of phases 9 and 10, and the parts of phase 11 discussed so far.
rohan-hotdata
requested review from
shefeek-jinnah
and removed request for
a team
October 16, 2026 08:25
| | Phase 8, `episodes="search"` at 64,000 characters | 45 on sample A, 45 on sample B, 12,849 and 12,676 reader tokens | | ||
| | Phase 8, `episodes="search"` at 32,000 characters | 43 on sample A, 5,715 reader tokens | | ||
| | Phase 8 misses with `search` at 64,000 characters | 9 on each sample: 5 with no stored fact, and an evidence session in the block in 8 | | ||
| | Phase 8 run time on sample A, 4 workers | 1,145 s for facts only, 1,507 s for `search` at 64,000 characters | |
There was a problem hiding this comment.
nit: Add the phase 8 run times to docs/benchmarks.md, or mark this row with its source. (not blocking)
The section header at line 44 states "All numbers are from docs/benchmarks.md". docs/benchmarks.md holds no 1,145 s or 1,507 s value. A reader then cannot trace this row to an observed run, as the AGENTS.md rule on measured numbers requires.
The seven phase 8 runs on sample A took 1,133 to 2,085 seconds, not 1,145 to 1,507. Both copies now name duration_s in the result files as the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes phase 8 in the roadmap and plans phases 9 to 11. It changes only
docs/internal/roadmap.mdanddocs/internal/plan.md.What changes
plan.mdholds the tasks of phases 9 and 10, with the same text as issues Phase 9: faster evaluation #25 and Phase 10: the ranking, and episode chunks #26.Verification
make verifypasses (238 passed, 119 skipped, links checked).