Repository navigation
feat(query): add arrow ipc stream response format - #216
Merged
Merged
Conversation
hotdata-automation
Bot
requested review from
shefeek-jinnah
and removed request for
a team
October 15, 2026 05:57
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| [ | ||
| 'application/json' | ||
| 'application/json', | ||
| 'application/vnd.apache.arrow.stream' |
There was a problem hiding this comment.
nit: Document that only query_without_preload_content() can return an Arrow body (not blocking).
The default Accept stays application/json, because select_header_accept picks the first JSON entry. A caller that passes _headers={'Accept': 'application/vnd.apache.arrow.stream'} to query() or query_with_http_info() fails. response_deserialize in hotdata/api_client.py:324 decodes the Arrow bytes as UTF-8 for the QueryResponse type. That decode raises UnicodeDecodeError or "Unsupported content type". Add one sentence to docs/QueryApi.md or the README that points Arrow users to query_without_preload_content(). Skip this fix if the generator templates cannot carry the note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www/pull/452