Skip to content

Restore the legacy "Portugese" locale alias - #40

Open
bluhm wants to merge 1 commit into
houseabsolute:masterfrom
bluhm:restore-portugese-alias
Open

Restore the legacy "Portugese" locale alias#40
bluhm wants to merge 1 commit into
houseabsolute:masterfrom
bluhm:restore-portugese-alias

Conversation

@bluhm

@bluhm bluhm commented Aug 31, 2026

Copy link
Copy Markdown

%DateTimeLanguageAliases exists to map the old DateTime::Language names onto CLDR locale codes. One of those names really is spelled "Portugese", so that misspelling is the load-bearing content of the key, not a typo in it. Restore the behavior before commit d7f22c6.

%DateTimeLanguageAliases exists to map the old DateTime::Language
names onto CLDR locale codes.  One of those names really is spelled
"Portugese", so that misspelling is the load-bearing content of the
key, not a typo in it.  Restore the behavior before commit d7f22c6.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@bluhm
bluhm force-pushed the restore-portugese-alias branch from 3c25573 to e68f7c1 Compare August 31, 2026 17:12
@autarch

autarch commented Sep 1, 2026

Copy link
Copy Markdown
Member

Hi, thanks for your PR!

I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is.

For larger PRs, I typically use the GitHub PR review process and provide feedback directly on the code, asking you to make some changes. For smaller PRs, where I just want to tweak some small stuff (like doc wording, comments, code formatting, etc.), I don't do a PR review.

Whether or not I do a review, there are two options for merging the PR:

  1. I check your PR out locally, fiddle with it as needed, merge it locally, and simply close the PR on GitHub. This will preserve at least one commit with your name on it, but the PR will show up as closed in your GitHub stats.
  2. If you enable me to push directly to your PR branch (which is the default when you make a PR), I can do my fiddling, then force push to your PR branch and merge the resulting PR. Again, this will preserve at least one commit with your name on it, but you also get credit for the PR merge in your GitHub stats. The only downside is that I will be force pushing directly to your PR branch. Note that this will not work if the PR branch is named master. GitHub doesn't allow me to push to the default branch of your fork.

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1.

Thanks again for your contribution!

@bluhm

bluhm commented Sep 1, 2026

Copy link
Copy Markdown
Author

I don't care much how you integrate this pull request. It was an AI finding during an OpenBSD ports update and it looked plausible to me. If there is a bug, fix it somehow. If there is no bug at all, just close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants