Skip to content

fix(tests): supply default group and update subject management tests - #392

Merged
trtajim merged 1 commit into
mainfrom
fix/subject-management-group-tests
Oct 7, 2026
Merged

trtajim merged 1 commit into
mainfrom
fix/subject-management-group-tests

Conversation

@trtajim

@trtajim trtajim commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Fixes CI test failures in SubjectManagementTest by defaulting group to science in StoreSubjectRequest and updating test payloads.

Summary by CodeRabbit

  • Bug Fixes
    • Subject creation now defaults the group to Science when no group is provided. Group values must still be one of Science, Humanities, Commerce, or Common.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: hscstack/platform/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 71aa55b2-d17b-41ee-812c-c76bbf0b19a3
📥 Commits

Reviewing files that changed from the base of the PR and between 6622a59 and 773157b.

📒 Files selected for processing (2)
  • app/Http/Requests/Subject/StoreSubjectRequest.php
  • tests/Feature/SubjectManagementTest.php
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@trtajim
trtajim merged commit e061dab into main Oct 7, 2026
5 of 6 checks passed
@trtajim
trtajim deleted the fix/subject-management-group-tests branch October 7, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant