Skip to content

Remove obsolete PEP 263 encoding hints - #135

Merged
mib1185 merged 1 commit into
hthiery:masterfrom
mib1185:remove-obsolete-code-encoding-definitions
Sep 18, 2026
Merged

mib1185 merged 1 commit into
hthiery:masterfrom
mib1185:remove-obsolete-code-encoding-definitions

Conversation

@mib1185

@mib1185 mib1185 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Since python 3 (PEP 3120) utf-8 is the default encoding, so the encoding hints are not necessary anymore.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved issues were identified that would block approval.

Pull request overview

Removes obsolete PEP 263 UTF-8 encoding comments from Python source and test files. The project explicitly supports Python 3.9+, where UTF-8 is the default source encoding.

Changes:

  • Removed encoding declarations from library modules.
  • Removed encoding declarations from tests and setup script.
  • No runtime behavior changed.
File summaries
File Description
tests/test_fritzhometrigger.py Updated as part of this pull request.
tests/test_fritzhometemplate.py Updated as part of this pull request.
tests/test_fritzhomedevicethermostat.py Updated as part of this pull request.
tests/test_fritzhomedevicethermostat_group.py Updated as part of this pull request.
tests/test_fritzhomedevicetemperature.py Updated as part of this pull request.
tests/test_fritzhomedeviceswitch.py Updated as part of this pull request.
tests/test_fritzhomedevicerepeater.py Updated as part of this pull request.
tests/test_fritzhomedevicepowermeter.py Updated as part of this pull request.
tests/test_fritzhomedevicelightbulb.py Updated as part of this pull request.
tests/test_fritzhomedevicebutton.py Updated as part of this pull request.
tests/test_fritzhomedeviceblind.py Updated as part of this pull request.
tests/test_fritzhomedevicebase.py Updated as part of this pull request.
tests/test_fritzhomedevicealarm.py Updated as part of this pull request.
tests/test_fritzhome.py Updated as part of this pull request.
setup.py Updated as part of this pull request.
pyfritzhome/fritzhomedevice.py Updated as part of this pull request.
pyfritzhome/fritzhome.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhometrigger.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhometemplate.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomeentitybase.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicethermostat.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicetemperature.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedeviceswitch.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicerepeater.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicepowermeter.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicelightbulb.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicelevel.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicehumidity.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicebutton.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedeviceblind.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicebase.py Updated as part of this pull request.
pyfritzhome/devicetypes/fritzhomedevicealarm.py Updated as part of this pull request.
pyfritzhome/cli.py Updated as part of this pull request.
Review details
  • Files reviewed: 33/33 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 96.909%. remained the same — mib1185:remove-obsolete-code-encoding-definitions into hthiery:master

@mib1185
mib1185 merged commit 4393bd1 into hthiery:master Sep 18, 2026
12 checks passed
@mib1185
mib1185 deleted the remove-obsolete-code-encoding-definitions branch September 18, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants