fix: use filesystem-safe encoding for lock file paths - #1964
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Unicode configuration paths encode to Base64 containing
/.open_with_lockfile()then treats that slash as a directory separator in the temporary lock path and raisesFileNotFoundErrorbefore opening the configuration file.Use URL-safe Base64 so the generated lock name stays a single filename. Add tests for Unicode paths, competing lock acquisition, reopening after release, and cleanup when the context raises, plus a changelog entry.
Validation: 17 utility/update-check tests pass, and changed-file Flake8 passes. The two new Unicode cases fail before the fix. A broader run encountered two Big5 charset-detection failures, both reproduced with unchanged upstream code; the full suite was interrupted during slow network tests, so I cannot claim a complete full-suite pass.