Conversation
findall() treated a match inside the body as the prefix and cut that many characters off the front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_prefixed_json('{{"a": 1}')returned the prefixaand the object{"a": 1}. The string is not JSON, andais not a prefix.re.findalltook a match from inside the body and cut that many characters off the front.The search is now anchored at the start.
while(1);{"a": 1}still returns the prefixwhile(1);and the object.{{"a": 1}raisesValueError.Fixes #1965
Test plan
test_prefixed_json_does_not_chop_inside_the_bodyfails on tip and passes withre.matchtest_json_formatter_with_body_preceded_by_non_json_datastill passes (224 cases)