Skip to content

fix(man_pages): correct broken Windows guard (closes #1898) - #1967

Open
Niranjan-png wants to merge 1 commit into
httpie:masterfrom
Niranjan-png:fix/issue-1898-win-guard
Open

Niranjan-png wants to merge 1 commit into
httpie:masterfrom
Niranjan-png:fix/issue-1898-win-guard

Conversation

@Niranjan-png

Copy link
Copy Markdown

Fixes broken Windows guard using sys.platform. Regression test added.

The guard compared the built-in function os.system to the string nt, which is always False. Replace with sys.platform == win32 and add import sys. Fixes httpie#1898
@Niranjan-png

Copy link
Copy Markdown
Author

Note on CI failures (verified facts only):

  • 5 failing tests: test_auth.py (2), test_cli_ui.py (1), test_encoding.py (2 — big5 charset detection).
  • My PR changes only: httpie/output/ui/man_pages.py (+2 -1) and new tests/test_issue_1898_regression.py.
  • The failing tests do not involve the changed files; they cover auth, CLI UI, and encoding areas unrelated to the fix.
  • I attempted to verify these failures on the base branch locally, but reproduction was blocked because pytest_httpbin is missing from the environment; I am not claiming conclusively that they fail on the base.
  • I have not modified PR fix(man_pages): correct broken Windows guard (closes #1898) #1967; please confirm whether these are known/pre-existing CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant