Scope daily ratings/reviews refresh to each app's tracked storefronts#5
Open
dustyberry1 wants to merge 1 commit into
Open
Conversation
The daily refresh built its request with storefrontSelection: .all(codes:) using the full bundled storefront catalog (~174 countries) for every tracked app. Ratings and reviews are fetched per storefront, so the refresh fanned out across all 174 countries regardless of how many the user actually tracked keywords in. For anyone tracking keywords in more than a few countries this made the daily/long refresh time out. Derive each app's storefront set from the countries it actually tracks keywords in (app.keywordTracks), via a new testable helper DailyRefreshScheduler.ratingsReviewsStorefrontCodes(for:fallback:). Apps with no tracked keywords fall back to the catalog-wide set so current behavior is preserved there. Add DailyRefreshSchedulerTests covering both the scoped and fallback cases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily refresh built its request with storefrontSelection: .all(codes:) using the full bundled storefront catalog (~174 countries) for every tracked app. Ratings and reviews are fetched per storefront, so the refresh fanned out across all 174 countries regardless of how many the user actually tracked keywords in. For anyone tracking keywords in more than a few countries this made the daily/long refresh time out.
Derive each app's storefront set from the countries it actually tracks keywords in (app.keywordTracks), via a new testable helper DailyRefreshScheduler.ratingsReviewsStorefrontCodes(for:fallback:). Apps with no tracked keywords fall back to the catalog-wide set so current behavior is preserved there.
Add DailyRefreshSchedulerTests covering both the scoped and fallback cases.