Mark KeywordRankingScreenshotExportService as Sendable#6
Open
dustyberry1 wants to merge 1 commit into
Open
Conversation
Under Swift 6.2 with SWIFT_STRICT_CONCURRENCY = complete (the project's settings), the screenshot export Task captures the KeywordRankingScreenshotExportService instance created on the main actor and calls its async export(...) across an actor boundary, which fails to compile: 'sending exporter risks causing data races'. The service is a final class whose only stored property is an already-Sendable ScreenshotDownloadService, with no mutable state, so it is safe to declare Sendable. This unblocks building on Xcode 26.5. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under Swift 6.2 with SWIFT_STRICT_CONCURRENCY = complete (the project's settings), the screenshot export Task captures the KeywordRankingScreenshotExportService instance created on the main actor and calls its async export(...) across an actor boundary, which fails to compile: 'sending exporter risks causing data races'.
The service is a final class whose only stored property is an already-Sendable ScreenshotDownloadService, with no mutable state, so it is safe to declare Sendable. This unblocks building on Xcode 26.5.