Skip to content

fix(cli): use canonical environment names in hud init #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solvemproblr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): use canonical environment names in hud init #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions hud/cli/init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,12 @@
import typer

from hud.utils.hud_console import HUDConsole
from hud.utils.naming import normalize_environment_name

from .presets import ENVIRONMENT_PRESETS, PRESETS_BY_ID, EnvironmentPreset, materialize_preset
from .templates import DOCKERFILE_HUD, ENV_PY, PYPROJECT_TOML, TASKS_PY


def _python_name(name: str) -> str:
"""Normalize a package name into a Python-identifier-ish env name."""
name = name.replace("-", "_").replace(" ", "_")
return "".join(c if c.isalnum() or c == "_" else "_" for c in name)


def _resolve_preset(preset: str | None, hud_console: HUDConsole) -> EnvironmentPreset | None:
"""Pick the starter: an explicit ``--preset`` id, an interactive choice, or
``None`` when there's no TTY to prompt.
Expand Down Expand Up @@ -157,7 +152,7 @@ def init_command(
raise typer.Exit(1) from exc
hud_console.status_item(f"{chosen.owner}/{chosen.repo}", "✓")
else:
_write_local_scaffold(target, _python_name(target.name), hud_console)
_write_local_scaffold(target, normalize_environment_name(target.name), hud_console)

hud_console.section_title("Next Steps")
hud_console.info("")
Expand Down
2 changes: 1 addition & 1 deletion hud/cli/tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def test_init_scaffolds_a_runnable_package(tmp_path: Path) -> None:
}

env_py = (target / "env.py").read_text()
assert 'Environment(name="my_cool_env")' in env_py
assert 'Environment(name="my-cool-env")' in env_py
assert (target / "tasks.py").read_text().startswith('"""')
assert 'name = "my-cool-env"' in (target / "pyproject.toml").read_text()

Expand Down
Loading