Add python_version input to doc build workflows#808
Open
FabienDanieau wants to merge 1 commit into
Open
Conversation
The build venv is created with a bare `uv venv`, which picks the runner's system Python (3.10 on ubuntu-22.04). Packages that require a newer Python (e.g. reachy_mini needs >=3.11) then fail to install: "current Python version (3.10.x) does not satisfy Python>=3.11". Add an optional `python_version` input, passed to `uv venv --python` so uv provisions that version. Unset by default, preserving current behavior for every other caller. Assisted-by: Claude:claude-opus-4-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
python_versioninput to both reusable build workflows (build_main_documentation.ymlandbuild_pr_documentation.yml). When set, the build venv is created with that Python:uv venv ${{ inputs.python_version && format('--python {0}', inputs.python_version) || '' }}Unset by default → bare
uv venv, i.e. no behavior change for any existing caller.Why
The build venv is currently created with a bare
uv venv, which picks the runner's system Python — 3.10 onubuntu-22.04. A documented package that requires a newer Python then can't be installed, and the build fails during "Setup environment":There's no way for a caller to select the interpreter today:
pre_commandruns after the venv is created, and a reusable workflow can't inherit env likeUV_PYTHONfrom the caller. This surfaced building the pollen-robotics/reachy_mini docs (requires-python = ">=3.11").uvprovisions the requested version automatically (the job already exportsUV_PYTHON_INSTALL_DIR), so callers just pass e.g.python_version: "3.11".