Fix BERT normalization of CJK Extension E boundary characters - #2395
Open
mottopanikeiku wants to merge 1 commit into
Open
mottopanikeiku wants to merge 1 commit into
mottopanikeiku wants to merge 1 commit into
Conversation
Correct the lower bound to U+2B820 and cover the omitted interval endpoints through the public Python normalizer. AI assistance was used. The submitting account owner confirmed review of this exact patch: this has been manually reviewed.
mottopanikeiku
marked this pull request as ready for review
September 9, 2026 00:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've corrected BERT's CJK Extension E lower bound from
U+2B920toU+2B820, matching original BERT and Unicode's block definition.The typo skips 256 ideographs. For example,
a\U0002B820bbecomes one[UNK]instead of preserving the known neighboringaandbtokens. The regression covers both ends of the omitted interval and keeps the existing common-Chinese case.Tests
handle_chinese_chars=False.Tested on Linux. Other platforms and Node bindings were not tested.
I used AI for this patch; this has been manually reviewed.