docs(tooling): translate build/CI, scripts, and pragent-shim comments/logs to English - #188
Merged
Conversation
Final code-comment layer (22 files): CI workflows, electron-builder.yml, electron.vite.config.ts, after-pack.cjs, assemble-pragent-runtime.mjs, the pragent-shim Python subsystem (14 files), and .gitignore comments. Beyond comments/docstrings, the developer-facing log/error OUTPUT strings in the dev scripts are also translated (per the logs/exceptions-in-English convention) — assemble-runtime logs, shim RuntimeError/_debug/_warn messages, after-pack logs. Functional strings (LLM prompts, config keys, sentinels, upstream-matched messages) left verbatim. Also fixes a stale doc path in .gitignore (modules/04 → arch/02-agent/05). Verified: node --check + py_compile + YAML parse all pass; prepare:pragent re-synced the shim and the smoke test passes (shim patch active). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The final layer of the code-comment English initiative — the build/tooling/CI + pragent-shim files my
src/-focused passes skipped. Completes the "developer-facing code-surface artifacts are English" convention across the whole repo. Follows #184 (packages), #185 (renderer), #186 (backend), #187 (styles).Scope (22 files)
.github/workflows/{ci-cli,release}.yml,apps/desktop/electron-builder.yml,electron.vite.config.ts,build-resources/after-pack.cjs,scripts/assemble-pragent-runtime.mjsBeyond comments/docstrings, the developer-facing log/error output strings in the dev scripts are also translated (per the logs/exceptions-in-English convention):
assemble-pragent-runtime.mjslog/fail output, shimRuntimeError/_debug/_warnmessages,after-pack.cjslogs.Also fixes a stale doc path in
.gitignore(docs/modules/04-…→docs/arch/02-agent/05-pragent-runtime.md).Left verbatim
Functional string literals: LLM prompt/instruction text, config/dict keys, YAML keys, sentinel tokens (
@@MEEBOX_USAGE@@,meebox:///,LOCAL__*), regex, and strings matched against upstream pr-agent/litellm messages..github/ISSUE_TEMPLATE/*.yml(user-facing issue-form content, not comments) is out of scope.Verification
node --check(mjs/cjs),py_compile(14 shim files), and YAML parse all pass.prepare:pragentre-synced the shim and the smoke test passes (pr_agent importable + shim patch active) — the definitive check for the shim changes; its own console output is now English too.Wrap-up
With this, all Chinese code comments across
apps/desktop(src + styles + tooling),packages/,tools/,typings/, and the shim are English. The Go CLI was already English.