feat(diff): Git LFS status on binary diffs + file-level comments - #211
Merged
Conversation
Binary files (images, office docs, PDFs, …) render a "binary, not rendered"
placeholder with no indication of whether they are Git LFS-managed. Detect LFS
and surface the status.
- repo-mirror getFileContent: detect the Git LFS pointer blob (the mirror never
smudges, so an LFS-managed file's content is the pointer text) and return it
as binary + the real byte size from the pointer, instead of dumping pointer
text as a bogus diff
- contract: extend FileContent / DiffFileContent binary variant with an optional
lfs { size } field
- DiffPane: on the binary placeholder show a "Git LFS · <size>" tag for
LFS-managed files, or a "⚠ Not LFS" tag for plain inline binaries (per side,
preferring head); i18n across all four locales
- test: cover LFS pointer detection + size parsing in repo-mirror
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…red) Comments could only be PR summaries or line-anchored inline comments. Add file-level comments — anchored to a whole file — which Bitbucket and GitHub support. Previously such remote comments were silently collapsed to summaries, losing their file association (notably Bitbucket file comments). - model: PrCommentAnchor.line/lineType become optional (absent line = file-level); comment kind gains 'file'; new capability fileLevelComments - adapters: Bitbucket maps/publishes a line-less anchor; GitHub uses subject_type: "file"; GitLab has no file-level diff-comment API → capability false + defensive guard (degrades to local menu / hides the entry) - ipc: comments:createFile channel + controller (posts via the inline-publish path with a line-less anchor) - renderer: a file-level comment strip above the diff editor shows the file's file-level comments (reusing CommentItem for full interaction parity) plus an icon "comment on file" entry (capability-gated); the header shows the file's project-relative path as a breadcrumb. CommentItem renders a path-only, non-clickable chip for file-level anchors and skips the line code context; useCommentZones excludes line-less anchors from Monaco line zones - docs: capability field + per-platform table + a file-level comments section in the comment-interactions design Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…eased Recreate the [Unreleased] section (consumed by the 0.11.0 release) with Added entries for the two features on this branch, in both locales. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
huhamhire
added
enhancement
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two diff/review improvements, plus a CHANGELOG entry for each.
1. Git LFS status on binary-file diffs (
2f4d14d)Binary files (images, office docs, PDFs, …) rendered a bare "binary, not rendered" placeholder with no hint of whether they were Git LFS-managed.
repo-mirrordetects the Git LFS pointer blob (the mirror never smudges, so an LFS file's content is the pointer text) and returns it as binary + the real byte size from the pointer, instead of dumping pointer text as a bogus diff.FileContent/DiffFileContentgain an optionallfs { size }field. Test covers pointer detection + size parsing.2. File-level comments (whole-file, not line-anchored) (
9f338c0)Comments could only be PR summaries or line-anchored inline comments. Bitbucket & GitHub also support file-level comments (anchored to a whole file); previously such remote comments were silently collapsed to summaries, losing their file association.
PrCommentAnchor.line/lineTypebecome optional (absent line = file-level); commentkindgains'file'; new capabilityfileLevelComments.subject_type: "file"; GitLab has no file-level diff-comment API → capabilityfalse+ defensive guard.CommentItemfor full interaction parity) and a path-only, non-clickable chip in the comments list.comments:createFile.docs/arch/01-platform/.Testing
lint→typecheck→test→buildall green.🤖 Generated with Claude Code