fix(chat): commit divider polish + persistent boundary - #218
Merged
Conversation
…n hover Two polish fixes for the run-timeline commit divider: - The chip's commit icon and short sha were flush and vertically misaligned (the chip mixin sets no gap). Add a small gap and make the svg a block so it aligns to the sha's line box. - The hover tooltip showed a generic "code changed" string. Show the new head commit's actual message instead (resolved via diff:listCommits — the head is the PR's newest introduced commit; main-cached), falling back to the short sha. This is more meaningful and removes the chatPane.commitDividerTitle i18n key from all four locales. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The bottom "stale head" divider vanished once a run was executed against the new commit (head then equalled the last run's headSha, so nothing was "stale"). Mark every point where the reviewed commit changes instead: - a divider before a run whose headSha differs from the previous run's — a durable boundary between the old-commit runs above and the new-commit runs below (so it no longer disappears after reviewing the new code); - a trailing bottom divider only while the head has advanced past the last run and no run against it exists yet (new commit not reviewed, incl. while a run is in flight). Drops the "suppress while a run is active" rule so it never flickers away. Tooltip messages come from a single sha→message map built from diff:listCommits, so all dividers resolve their own commit message. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-up fixes to the ChatPane commit divider (from #216).
1. Chip gap / alignment + real commit message on hover (
900e882)diff:listCommits), falling back to the short sha. Removes thechatPane.commitDividerTitlei18n key from all four locales.2. Keep the divider as a persistent boundary (
ec2751f)The bottom "stale head" divider vanished once a run was executed against the new commit (head then equalled the last run's headSha → nothing "stale"). Now mark every point where the reviewed commit changes:
headShadiffers from the previous run's — a durable boundary between the old-commit runs above and the new-commit runs below (no longer disappears after reviewing the new code);Drops the "suppress while a run is active" rule so it never flickers away. Tooltip messages come from a single sha→message map (
diff:listCommits), so every divider resolves its own commit message.Checks
lint+typecheck+build(desktop) pass locally.