Skip to content

fix(chat): commit divider polish + persistent boundary - #218

Merged
huhamhire merged 2 commits into
devfrom
fix/commit-divider-polish
Jul 28, 2026
Merged

fix(chat): commit divider polish + persistent boundary#218
huhamhire merged 2 commits into
devfrom
fix/commit-divider-polish

Conversation

@huhamhire

Copy link
Copy Markdown
Owner

Two follow-up fixes to the ChatPane commit divider (from #216).

1. Chip gap / alignment + real commit message on hover (900e882)

  • The chip's commit icon and short sha were flush and vertically misaligned (the chip mixin sets no gap). Add a small gap and make the svg a block so it aligns to the sha's line box.
  • The hover tooltip showed a generic "code changed" string. Show the new head commit's actual message instead (resolved via diff:listCommits), falling back to the short sha. Removes the chatPane.commitDividerTitle i18n key from all four locales.

2. Keep the divider as a persistent boundary (ec2751f)

The bottom "stale head" divider vanished once a run was executed against the new commit (head then equalled the last run's headSha → nothing "stale"). Now mark every point where the reviewed commit changes:

  • a divider before a run whose headSha differs from the previous run's — a durable boundary between the old-commit runs above and the new-commit runs below (no longer disappears after reviewing the new code);
  • a trailing bottom divider only while the head has advanced past the last run and no run against it exists yet (new commit not reviewed, incl. while a run is in flight).

Drops the "suppress while a run is active" rule so it never flickers away. Tooltip messages come from a single sha→message map (diff:listCommits), so every divider resolves its own commit message.

Checks

lint + typecheck + build (desktop) pass locally.

huhamhire and others added 2 commits July 28, 2026 09:21
…n hover

Two polish fixes for the run-timeline commit divider:

- The chip's commit icon and short sha were flush and vertically misaligned
  (the chip mixin sets no gap). Add a small gap and make the svg a block so it
  aligns to the sha's line box.
- The hover tooltip showed a generic "code changed" string. Show the new head
  commit's actual message instead (resolved via diff:listCommits — the head is
  the PR's newest introduced commit; main-cached), falling back to the short
  sha. This is more meaningful and removes the chatPane.commitDividerTitle i18n
  key from all four locales.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The bottom "stale head" divider vanished once a run was executed against the
new commit (head then equalled the last run's headSha, so nothing was
"stale"). Mark every point where the reviewed commit changes instead:

- a divider before a run whose headSha differs from the previous run's — a
  durable boundary between the old-commit runs above and the new-commit runs
  below (so it no longer disappears after reviewing the new code);
- a trailing bottom divider only while the head has advanced past the last
  run and no run against it exists yet (new commit not reviewed, incl. while a
  run is in flight).

Drops the "suppress while a run is active" rule so it never flickers away.
Tooltip messages come from a single sha→message map built from
diff:listCommits, so all dividers resolve their own commit message.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@huhamhire huhamhire added the bug Something isn't working label Jul 28, 2026
@huhamhire
huhamhire merged commit 6548889 into dev Jul 28, 2026
1 check passed
@huhamhire
huhamhire deleted the fix/commit-divider-polish branch July 28, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant