Repository navigation
fix(web): a chat folded away still asks until its reply is seen - #544
Merged
Merged
Conversation
A chat between turns folds away once no page follows it, and its host's question goes with it, so its row lost the blinking asking mark before anyone read the reply. The page now remembers what each chat last waited on until a turn of it opens, and keeps it asking until that is seen. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
askingdrops to[]and the gold blinking mark turned grey before anyone had read the reply.localStorageunderhmz-owed, what each chat last waited on, and forgets it once a turn opens. A folded chat staysaskinguntil that is seen. Opening its page marks it seen, and it then showsstopped.runningwith no host, because its lock is still held. That no longer clears what it owes; only a turn its host says is open does.web.md§5.10 anddocs/user/web.mdare updated to match.Follows #542 and #543.
Test plan
test_a_chat_answered_unread_still_asks_once_folded_until_one_looks(Chromium and WebKit). It fails without the fix and passes with it.uv run pytest: 6731 passed.pre-commit run --all-filesis clean.tests/system/web: 200 passed. The 2 failures,test_web_daemon_bar, fail the same way on main on this machine.🤖 Generated with Claude Code