Add socket support - #2
Draft
rmccue wants to merge 4 commits into
Draft
Conversation
Unlike the other string components, the payload can represent raw binary data, so we should move the encoding and decoding up to the highest layer we can.
rmccue
marked this pull request as draft
November 9, 2022 17:11
Member
Author
|
I'm experiencing an occasional issue where data encoding seems to have some problem when connecting a MySQL client, so digging into whether that's an issue with the encoding. |
Member
|
@rmccue wondering if we could merge for the Logger support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for port forwarding connections using raw sockets.
writeRawmethod) and output (rawOutputevent) handlers to take raw data as Uint8Array instead of UTF-8 encoded string