Skip to content

rename jobType to requestType in manifests and related functions for… #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
portuu3 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

rename jobType to requestType in manifests and related functions for… #3908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b0b2dc
rename jobType to requestType in manifests and related functions for…
portuu3 May 21, 2026
e9b6541
Merge branch 'develop' into requesttype
May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/apps/reputation-oracle/server/src/common/types/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ import {
} from '@/common/enums';

export interface BaseManifest<
TJobType extends FortuneJobType | MarketingJobType,
TRequestType extends FortuneJobType | MarketingJobType,
> {
submissionsRequired: number;
jobType: TJobType;
requestType: TRequestType;
}

export type FortuneManifest = BaseManifest<FortuneJobType>;
Expand Down
2 changes: 1 addition & 1 deletion .../reputation-oracle/server/src/modules/escrow-completion/escrow-completion.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ describe('EscrowCompletionService', () => {
);

const manifest = generateFortuneManifest();
jobRequestType = manifest.jobType;
jobRequestType = manifest.requestType;
mockedEscrowUtils.getEscrow.mockResolvedValue({
manifest: faker.internet.url(),
} as unknown as IEscrow);
Expand Down
2 changes: 1 addition & 1 deletion packages/apps/reputation-oracle/server/src/modules/escrow-completion/fixtures/fortune.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {

export function generateFortuneManifest(): FortuneManifest {
return {
jobType: FortuneJobType.FORTUNE,
requestType: FortuneJobType.FORTUNE,
submissionsRequired: faker.number.int({ min: 2, max: 5 }),
};
}
Expand Down
2 changes: 1 addition & 1 deletion packages/apps/reputation-oracle/server/src/modules/escrow-completion/fixtures/marketing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {

export function generateMarketingManifest(): MarketingManifest {
return {
jobType: MarketingJobType.SOCIAL_MEDIA_PROMOTION,
requestType: MarketingJobType.SOCIAL_MEDIA_PROMOTION,
submissionsRequired: faker.number.int({ min: 2, max: 5 }),
};
}
Expand Down
4 changes: 2 additions & 2 deletions ...rver/src/modules/escrow-completion/payouts-calculation/default-payouts-calculator.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe('DefaultPayoutsCalculator', () => {
rejectedResult,
]);
const manifest: BaseManifest<MarketingJobType> = {
jobType: MarketingJobType.SOCIAL_MEDIA_PROMOTION,
requestType: MarketingJobType.SOCIAL_MEDIA_PROMOTION,
submissionsRequired: faker.number.int({ min: 2, max: 5 }),
};

Expand Down Expand Up @@ -105,7 +105,7 @@ describe('DefaultPayoutsCalculator', () => {
escrowAddress: faker.finance.ethereumAddress(),
finalResultsUrl: faker.internet.url(),
manifest: {
jobType: MarketingJobType.SOCIAL_MEDIA_PROMOTION,
requestType: MarketingJobType.SOCIAL_MEDIA_PROMOTION,
submissionsRequired: faker.number.int({ min: 2, max: 5 }),
},
});
Expand Down
2 changes: 1 addition & 1 deletion ...acle/server/src/modules/escrow-completion/results-processing/default-results-processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class DefaultResultsProcessor extends BaseEscrowResultsProcessor<DefaultR
throw new Error('No final results found');
}

if (manifest.jobType !== FortuneJobType.FORTUNE) {
if (manifest.requestType !== FortuneJobType.FORTUNE) {
return;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/apps/reputation-oracle/server/src/utils/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ function assertValidJobRequestType(
export function getJobRequestType(manifest: JobManifest): JobRequestType {
let jobRequestType: string | undefined;

if ('jobType' in manifest) {
jobRequestType = manifest.jobType;
if ('requestType' in manifest) {
jobRequestType = manifest.requestType;
} else if ('annotation' in manifest) {
jobRequestType = manifest.annotation.type;
}
Expand Down
Loading