Fix/incomplete response contract - #141
Merged
Merged
Conversation
ErrLLMTruncated / ErrLLMContentBlocked, carried by IncompleteResponseError, so a cut-off response stops surfacing as a decode error against the caller's schema. Blocked stops are non-retryable; the retry content gate now also covers the first attempt, so a truncation never replays its own stream.
Gemini never read FinishReason and OpenAI never read finish_reason, so a cap or content filter returned a valid prefix as a success; Anthropic only emitted a cap event. All three now return IncompleteResponseError, with the partial content and usage still on the result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #
Changes
Testing
Checklist
feat:,fix:,docs:,refactor:,chore:, …)gofmt -l .prints nothingmake lintis cleanmake buildpassesmake test(ormake test-racefor concurrency changes) passesfmt.Errorf("<pkg>: ...: %w", err))CHANGELOG.mdupdated if this PR is cut as a release tagpkg/llm/,pkg/history/, orpkg/telemetry/without explicit maintainer approval