Repository navigation
Fix #2718: match the Recording label in the status_capture_health smoke - #2719
Merged
Merged
Conversation
#2538 renamed the hyp status client label from Attached to Recording, and this smoke's healthy-case check still expected "Attached (otel)", so the smoke failed on master at its first check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2718
Cause
#2538 (2026-10-06, "Detach stops recording a client; attach resumes it") renamed the client status label in
src/core/commands/status.js:356fromAttachedtoRecording. Thestatus_capture_healthsmoke's first healthy-case check still matched/claude\s+Attached \(otel\)\s+Local only/, so the smoke has failed on master since then. Smokes do not run in CI, so nothing caught it.Fix
One regex in
hypaware-core/smoke/flows/status_capture_health.js:168now matchesRecording (otel). Nothing else changes.Evidence
HYP_HOME: FAIL athealthy: configured client and sharing policy render. The rendered value showsclaude Recording (otel) Local only. "Daemon Not running" is expected, because the smoke never starts a daemon.smoke status_capture_health: ok.npm run typecheck: pass.Old label elsewhere
grep -rn Attached hypaware-core/smoke/flowson this branch finds no matches, so no other smoke still references the old label.The release checklist in CLAUDE.md is unchanged. It does not list this smoke, and no doc or LLP says it belongs there.
Server-suite gate: not triggered (test-only change to one smoke flow).
🤖 Generated with Claude Code