Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Contributor
|
Could we instead copy it alongside the original runtime binary but appending a hash, something like hyperlight-wasm-runtime-xXxXxX, where we compute the hash from the features, profile, and crate source path? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the selected runtime into
OUT_DIRand use that copy for embedding.Default and
trace_guestbuilds share one runtime output path. Atrace_guestbuild can overwrite that file while Cargo retains the default build script's cached output. A later default library compilation then embeds the trace-enabled runtime.Each configuration's
OUT_DIRcopy preserves its runtime. The nested Cargo target directory remains shared to reuse compiled dependencies. Custom runtimes supplied throughHYPERLIGHT_JS_RUNTIME_PATHretain their existing environment and source-file tracking.Original Reproduction
Before this fix, the third build embedded the trace-enabled runtime despite requesting default
Uses the same approach as in in hyperlight-dev/hyperlight-wasm#551.
Fixes #296