Skip to content

ci(rhodibot): switch to the report-only canary (standards#759) - #73

Merged
hyperpolymath merged 1 commit into
mainfrom
refactor/rhodibot-canary
Sep 19, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
refactor/rhodibot-canary

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The RSR workflow in this repository is the mutating variant of rhodibot: it runs on a
weekly cron with contents: write + pull-requests: write, deletes files by glob, and
bulk-rewrites SPDX headers — which the standing licence policy forbids. It also interpolates
${{ steps.fix.outputs.FIXES }} into a run: block (repo-derived filenames, so
attacker-influenceable) and hardcodes a personal e-mail address.

This replaces it with the report-only canary that the estate template already ships — the
already-approved design, not a new one. Same weekly schedule, same drift signal, no mutation:
it reports what an auto-fixer would have changed and fails the run when it finds drift,
rather than editing anything. Licence/SPDX drift is reported for manual, owner-only
correction; rhodibot must never edit a licence header.

Part of the standards#759 migration (canary propagation, option (a)). The workflow's uses:
pins are unchanged, so actions.lock is unaffected.

The RSR workflow here is the mutating variant: weekly cron, write permissions,
glob deletes, a bulk SPDX `sed` sweep the licence policy forbids, a
`${{ steps.fix.outputs.FIXES }}` injection sink, and a hardcoded personal
e-mail. Replaced with the canary the template ships: same schedule, same drift
signal, reports instead of mutating.

Refs hyperpolymath/standards#759 (option (a), canary propagation).
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c7cb1a56-9b7a-4976-9843-c52ccb4e961f

📥 Commits

Reviewing files that changed from the base of the PR and between b8df630 and 104b62f.

📒 Files selected for processing (1)
  • .github/workflows/rhodibot.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (6)
  • GitHub Check: rust-ci / Cargo check + clippy + fmt
  • GitHub Check: Dogfooding compliance summary
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: analyze (actions, none)
🔇 Additional comments (1)
.github/workflows/rhodibot.yml (1)

1-44: LGTM!

Also applies to: 47-94


📝 Summary

Summary by CodeRabbit

  • Changed
    • Compliance checks now report repository drift without automatically modifying files or opening pull requests.
    • Findings are displayed as warnings and included in the workflow summary.
    • Workflow runs fail when actionable compliance drift is detected.
    • Licence inconsistencies are reported for manual correction.
    • Verification-bypass patterns are reported as advisory notes only.

Walkthrough

The RSR workflow changed from an auto-fixing job to a report-only canary. It now uses read-only permissions, reports detected drift through annotations and job summaries, and fails when drift exists.

Changes

RSR compliance canary

Layer / File(s) Summary
Workflow controls
.github/workflows/rhodibot.yml
The workflow now runs on the Monday schedule and manual dispatch. It uses read-only contents permission, concurrency cancellation, a 15-minute timeout, and the canary job name.
Drift detection and reporting
.github/workflows/rhodibot.yml
Checks now report would-delete, would-rename, would-create, unfixable, duplicate, stub, and SPDX findings. They no longer modify files or create pull requests.
Advisory scans and result handling
.github/workflows/rhodibot.yml
Verification-bypass patterns produce advisory notes. A positive drift count writes a summary, emits an error annotation, and exits with status 1. A zero drift count writes a clean-status summary.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 104b6

The report-only canary retains its intended advisory warning behavior and no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose and key changes, but it does not follow the required template. It omits the required headings, checklist, testing details, and screenshots section. Rewrite the description using the repository template. Add the Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections. Complete the applicable checklist items and describe the tests that were run, or state why they were …
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: switching rhodibot to a report-only canary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Rewrite the description using the repository template. Add the Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections. Complete the applicable checklist items and describe the tests that were run, or state why they were not applicable.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each file with care
No fixer paws disturb the lair
Warnings mark the drifting trail
A clean run leaves no failed tale
The canary guards the codebase well

Comment @coderabbitai help to get the list of available commands.

steps:
- name: Checkout
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v4
uses: actions/checkout@v7.0.1
@hyperpolymath
hyperpolymath merged commit 7e2dbce into main Sep 19, 2026
27 of 33 checks passed
@hyperpolymath
hyperpolymath deleted the refactor/rhodibot-canary branch September 19, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants