Skip to content

fix(ci): pin third-party actions to full commit SHAs - #98

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions
Sep 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

fix(ci): pin third-party actions to full commit SHAs

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — startup_failure, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. actions/checkout@<sha> # v4.

dtolnay/rust-toolchain takes its toolchain from the ref itself, so those steps also gained an
explicit with: toolchain: input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — `startup_failure`, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. `actions/checkout@<sha> # v4`.

`dtolnay/rust-toolchain` takes its toolchain from the ref itself, so those steps also gained an
explicit `with: toolchain:` input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0ae372b6-ebc8-4cb7-bed2-c33c5fe20c26

📥 Commits

Reviewing files that changed from the base of the PR and between d93128d and 93ec795.

📒 Files selected for processing (1)
  • .github/workflows/main-estate-audit.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (32)
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: check
  • GitHub Check: security
  • GitHub Check: Code Quality
  • GitHub Check: Test Suite
  • GitHub Check: Build Assets
  • GitHub Check: Dependency Review
  • GitHub Check: analyze (actions, none)
  • GitHub Check: estate-audit
  • GitHub Check: RSR Compliance Check
  • GitHub Check: Build Container Image
  • GitHub Check: build
  • GitHub Check: lint-workflows
  • GitHub Check: GitGuardian Security Checks
  • GitHub Check: lint-workflows
🔇 Additional comments (1)
.github/workflows/main-estate-audit.yml (1)

16-16: LGTM!

Also applies to: 19-19, 22-22, 25-25, 28-28, 31-31, 34-34, 37-37, 40-40, 43-43, 46-46, 49-49, 52-52, 55-55, 58-58, 61-61, 64-64, 67-67, 70-70, 73-73, 76-76, 79-79, 82-82, 85-85, 88-88, 91-91


📝 Summary

Summary by CodeRabbit

  • Chores
    • Pinned automated estate audit actions to fixed versions for more consistent and reproducible workflow runs.
    • Preserved the existing audit steps and execution order.

Walkthrough

The estate audit workflow pins actions/checkout and all 26 cicd-suite gates to fixed commit SHAs. Step names, order, structure, and previous tag comments remain unchanged.

Changes

Estate audit workflow

Layer / File(s) Summary
Pin workflow action references
.github/workflows/main-estate-audit.yml
The workflow replaces floating tags with immutable commit SHAs. Existing steps and comments remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: metadatastician

Merge Risk: ⚪ Minimal · up to 93ec7

This change only pins the continuous-integration workflow to fixed action versions so runs are reproducible; the checked action references are valid and no behavior change was found, so it is safe to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose, policy requirement, startup failure, SHA pinning, preserved references, and Rust toolchain handling. However, it does not follow the required template structure a… Update the description to use the repository template. Mark the applicable change type, list the changes, document the test environment and test results, complete the relevant checklist items, and provide related issues or state that none a…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: pinning third-party CI actions to full commit SHAs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the purpose, policy requirement, startup failure, SHA pinning, preserved references, and Rust toolchain handling. However, it does not follow the required template structure and omits the Type of Change, Related Issues, Changes Made, Testing, Checklist, and other required sections.

Resolution

Update the description to use the repository template. Mark the applicable change type, list the changes, document the test environment and test results, complete the relevant checklist items, and provide related issues or state that none apply.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 13bb258 into main Sep 20, 2026
23 of 36 checks passed
@hyperpolymath
hyperpolymath deleted the fix/sha-pin-actions branch September 20, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant