docs: add Signed commits section to CONTRIBUTING - #105
Conversation
Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (21)
|
| Layer / File(s) | Summary |
|---|---|
Signing and merge requirements .github/CONTRIBUTING.md |
The guide specifies signing methods for people, interactive agents, apps, bots, and workflows. It also documents squash merges, unsigned commits, and the disabled rebase-merge option. |
Priority: ⬇️ Low
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Merge Risk: ⚪ Minimal · up to 891a5
The guide documents signing workflows and squash merging. Whether rebase merging is also allowed could not be confirmed, so no actionable merge blocker is established.
Architecture Summary
Architecture risk: 🔵 Low · up to 891a5
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.
Review details
Before / after behavior
- observed — Modified behavior in .github/CONTRIBUTING.md: Added guidance requiring signed commits on the default branch, specifying SSH signing and verified committer email for people and interactive agents, API-based signed commits for apps, bots, and workflows, and squash merges. The section states that unsigned commits block PR merges, recommends recreating affected branches with signed cherry-picks, and says rebase-merge is disabled.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely describes the documentation change: adding a Signed commits section to CONTRIBUTING. |
| Description check | ✅ Passed | The description directly explains the Signed commits documentation change, its policy basis, and the signing requirements for contributors and automated systems. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit signs each commit with care,
SSH keys make the mark clear.
Squash the branches, keep checks in sight,
Cherry-pick signed commits right.
The guide now tells the path to take.
Comment @coderabbitai help to get the list of available commands.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The documentation accurately reflects the linked signing policy and GitHub ruleset behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds repository-specific signed-commit guidance aligned with estate policy.
Changes:
- Documents SSH signing for people and interactive agents.
- Defines API-based signing for automation and squash-only merging.
| File | Description |
|---|---|
.github/CONTRIBUTING.md |
Adds signed-commit requirements and remediation guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is
docs/SIGNING-POLICY.adocin hyperpolymath/standards.This repo's default branch is covered by the zero-bypass
Require-Signed-Commitsruleset, and rebase-merge is off. The section tells contributors what that requires:If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).
This is a docs-only change. The commit was created through
createCommitOnBranch, so GitHub signs it.🤖 Generated with Claude Code
https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f