-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): pin third-party actions to full commit SHAs #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,7 +62,7 @@ jobs: | |
| mkdir -p benchmark-results | ||
| idris2 --exec bench/VocabularyBench.idr > benchmark-results/$(date +%Y%m%d-%H%M%S).txt | ||
| - name: Upload benchmark results | ||
| uses: actions/upload-artifact@v3 | ||
| uses: actions/upload-artifact@ff15f0306b3f739f7b6fd43fb5d26cd321bd4de5 # v3 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win Migrate the artifact actions from v3 to v4. These changed references pin retired v3 artifact actions. GitHub no longer supports the v3 artifact actions on GitHub.com since 30 January 2025, so the SHA pins do not prevent these jobs from failing. Use matching v4 full commit SHAs at every upload and download site. (github.blog)
📍 Affects 2 files
🤖 Prompt for AI AgentsSource: MCP tools |
||
| with: | ||
| name: benchmark-results | ||
| path: /var/mnt/eclipse/repos/developer-ecosystem/idris2-ecosystem/echidna/benchmark-results/ | ||
|
|
@@ -74,7 +74,7 @@ jobs: | |
| - name: Checkout repository | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| - name: Download benchmark results | ||
| uses: actions/download-artifact@v3 | ||
| uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3 | ||
| with: | ||
| name: benchmark-results | ||
| - name: Analyze regression | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Replace retired v3 artifact actions.
GitHub.com stopped supporting
actions/upload-artifactandactions/download-artifactv3 on January 30, 2025. Pinning those retired versions to a SHA does not prevent the affected workflows from failing. (github.blog)asdf-augmenters/asdf-acceleration-middleware/.github/workflows/release.yml#L69-L69: replaceactions/upload-artifactv3 with a verified, pinned v4 commit.asdf-augmenters/asdf-acceleration-middleware/.github/workflows/release.yml#L79-L79: replaceactions/download-artifactv3 with a verified, pinned v4 commit in the same workflow.asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml#L101-L101: replaceactions/upload-artifactv3 with a verified, pinned v4 commit.📍 Affects 2 files
asdf-augmenters/asdf-acceleration-middleware/.github/workflows/release.yml#L69-L69(this comment)asdf-augmenters/asdf-acceleration-middleware/.github/workflows/release.yml#L79-L79asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml#L101-L101🤖 Prompt for AI Agents