docs: add Signed commits section to CONTRIBUTING - #83
Conversation
Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (14)
|
| Layer / File(s) | Summary |
|---|---|
Commit signing and merge rules .github/CONTRIBUTING.md |
The guide specifies signing settings and a verified committer email for people and interactive agents. It directs apps, bots, and workflows to use GitHub’s API or the estate action. It also requires squash merges and describes the checks and restrictions for unsigned commits. |
Priority: ⬇️ Low
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Merge Risk: ⚪ Minimal · up to 265e6
The guide clarifies signed-commit and squash-merge expectations. No actionable conflict is established, so this change appears ready to merge.
Architecture Summary
Architecture risk: 🔵 Low · up to 265e6
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.
Review details
Before / after behavior
- observed — Modified behavior in .github/CONTRIBUTING.md: Adds signed-commit requirements and distinguishes signing procedures for people and interactive agents versus apps, bots and workflows. It also specifies squash merging, states that every commit on the PR branch is checked, and says unsigned commits block merging, rebase-merges are disabled, and affected branches must be recreated with signed commits.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the purpose and key changes, but it omits the required RSR Quality Checklist and separate Testing and Screenshots sections from the repository template. | Add the template sections. Complete the RSR Quality Checklist, describe the tests or state why testing is not applicable, and state whether screenshots or terminal output are applicable. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the main change: adding signed-commit guidance to CONTRIBUTING.md. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
I’m a rabbit with a signed-up leaf,
I hop through commits, neat and brief.
Squash the branch and check each line,
My carrot patch is signed just fine.
I thump my paws; the rules are clear,
Safe little commits for all to cheer.
Comment @coderabbitai help to get the list of available commands.
Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is
docs/SIGNING-POLICY.adocin hyperpolymath/standards.This repo's default branch is covered by the zero-bypass
Require-Signed-Commitsruleset, and rebase-merge is off. The section tells contributors what that requires:If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).
This is a docs-only change. The commit was created through
createCommitOnBranch, so GitHub signs it.🤖 Generated with Claude Code
https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f