docs: make PROOF-PROGRESS true, amend ADR-0002 OPAQUE triggers, record D4 - #44
Merged
Merged
Conversation
…d D4 - PROOF-PROGRESS.adoc: rewritten against the code at 7ec7e08. The old version said "implementation not started" and invented an M0-M4 milestone scheme that PLAN.adoc never had. It now maps to PLAN's M0-M8: M0-M3 landed, M4 in progress, M5-M8 not started. Also records the finding.rs invariants (verified) and the known gaps, including #43. - ADR-0002 amendment (owner-ratified, selector R8): adds two OPAQUE triggers. `except*` parses as an ordinary except_clause with an anonymous `*` child, and has_error() is false, so it needs a structural detector. The second is a parse error in the unit. Also corrects the `except E as e` binding path: it is value: as_pattern -> alias: as_pattern_target, not except_clause.alias. - OWNER-DECISIONS: D4 ratified. Adopt the RSR Rust template now; the adoption lands as its own PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
Contributor
|
Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only. Carries out three owner rulings (selector R8/R9).
PROOF-PROGRESS.adoc: checked against PLAN and corrected
The old file said "implementation not started". It also used an M0–M4 scheme that PLAN.adoc never had. It is now rewritten against
mainat7ec7e08:RawFindinghas norule_id, andFindingWirehas noevidencefield.ADR-0002 amendment
except*(PEP 654). Measured against the pinned tree-sitter-python 0.25.0,except*parses as an ordinaryexcept_clausewith an anonymous*child. There is noexcept_group_clauseandhas_error()is false, so a structural detector is required.except E as ebinding lives atvalue: (as_pattern … alias: (as_pattern_target …)), not atexcept_clause.alias.OWNER-DECISIONS: D4 ratified
The RSR Rust template is adopted now. The adoption lands as its own PR, with each workflow shown to spawn jobs under
sha_pinning_required.🤖 Generated with Claude Code
https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f