Skip to content

Debtfile gate-scripts-without-tests probe cannot see actions-policy-486-test.sh (over-counts by up to 3) #1080

Description

@hyperpolymath

Defect

The Debtfile probe for gate-scripts-without-tests treats a script as tested only if one of these files exists: scripts/tests/<b>-test.sh, <b#check->-test.sh or <b#run->-test.sh.

scripts/tests/actions-policy-486-test.sh already tests three scripts: check-actions-policy.sh, set-allowed-actions.sh and rsr-selfaudit.sh. Its name matches none of the three patterns, so the probe counts all three as untested. The committed count is therefore inflated by up to 3. A number the ratchet enforces should measure the truth.

Acceptance criteria

  • Choose one fix, and record it as the owner's choice:
    • (a) Rename the test to a name the probe recognises. Note that one file can only match one script this way.
    • (b) Widen the probe, for example so a test counts as covering a script when it names that script in a SCRIPT=/CHECK=/SET= assignment.
  • Re-measure the count, and let the ceiling fall with it (a fall is free under the ratchet).
  • Add a positive control: temporarily remove actions-policy-486-test.sh, and the count must rise.

Found while writing #1078.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    governancePolicy, rulesets, standards, compliance, and their enforcementpriority:p2Normal - queue itscope:repoConfined to this repositorytestingTests, benchmarks, fuzzing, property checks, coverage

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions