docs(builder): clean SECURITY.md commit (remove real email from commit body) - #93
Closed
iap wants to merge 1 commit into
Closed
docs(builder): clean SECURITY.md commit (remove real email from commit body)#93iap wants to merge 1 commit into
iap wants to merge 1 commit into
Conversation
GitHub auto-generates a default security policy page, but there was no SECURITY.md in the repo. Create one with the project-specific contact email and GPG key for vulnerability reporting, rather than the generic GitPod redirect that GitHub defaults to.
|
|
||
| ### How to Report | ||
|
|
||
| - **Email**: `iap@users.noreply.github.com` (GPG: `0049 2CBB E90A F475 521F 68B9 9166 D30F 6FE7 0F56`) |
There was a problem hiding this comment.
Security reporting email cannot receive messages
iap@users.noreply.github.com is a GitHub noreply identity address, not a maintainer-controlled inbox. DNS and SMTP routing checks for that exact recipient found no MX record or fallback address, so researchers who use the documented email option cannot deliver a report or receive the stated acknowledgment. Replace it with a monitored maintainer mailbox, or remove the email option and direct reporters exclusively to monitored GitHub Security Advisories.
Owner
Author
|
Closed: changes applied via PR #95 merge. No real email remains in file content or PR bodies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The squash merge commit fb4a9b5 on main contains the real email (iap@disroot.org) in the commit message body. This PR replaces it with a clean commit that uses no-reply email in file content and removes the real email from the commit message body. This is a rebase from PR #91 + the clean SECURITY.md commit.
Greptile Summary
This change adds a security policy covering vulnerability-report contents, response expectations, scope, and reporting channels. The listed email channel cannot receive reports because the GitHub noreply address has no mail-delivery route. Replace it with a monitored mailbox or remove the email option and direct reporters to a monitored GitHub Security Advisory channel.
Merge safety: not safe to merge until the reporting contact is made reachable.
Confidence Score: 3/5
The policy should not be merged as written because one advertised security-reporting channel is unreachable.
The exact documented recipient was checked through DNS/MX lookup and an SMTP connection attempt. Both demonstrated that mail cannot be routed to the address, and GitHub documentation identifies the address format as a noreply identity address rather than an inbound mailbox.
Files Needing Attention: SECURITY.md line 9 needs a monitored reporting address or removal of the email reporting option.
Security Review
The security policy advertises an email reporting channel that cannot receive inbound messages. This can prevent researchers from privately reporting vulnerabilities and disrupt coordinated disclosure.
What T-Rex did
Comments Outside Diff (1)
General comment
SECURITY.md:9directs reporters toiap@users.noreply.github.com. The concrete DNS and SMTP routing checks for that exact address found no MX record, no fallback A/AAAA address, and therefore no reachable SMTP destination. A security report sent there cannot be delivered to a maintainer.Reviews (1): Last reviewed commit: "docs(builder): add proper SECURITY.md wi..." | Re-trigger Greptile