fix(web): mobile header FAB + ModelAlias props - #761
Open
Shunamxiao wants to merge 1 commit into
Open
Conversation
- Header: force brand name to a single line; on <sm screens the language toggle, theme toggle, and Add Account button collapse into a bottom-right FAB (logout icon kept). - ModelAliasSettings: define the ModelAliasSettingsProps interface so the models prop types correctly; SettingsTab passes models through. - ModelAliasSettings.test: pass the required models prop. Verified: vite build OK (78 modules), ModelAliasSettings.test passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
1. Header mobile layout — On screens
<sm, the language toggle, theme toggle, and Add Account button were crowding the brand name and overlapping. They now collapse into a floating action button (FAB) pinned bottom-right (brand title forced to a single line, logout icon kept).2. ModelAlias settings types — Define the
ModelAliasSettingsPropsinterface so themodelsprop (used for the target<datalist>) types correctly;SettingsTabpassesmodelsthrough; test updated to pass the required prop.Verification
vite buildsucceeds (78 modules, esbuild)vitestpasses forModelAliasSettings.test.tsx