Skip to content

Simplify stack tooling and local CCC workflow#24

Merged
phroi merged 9 commits intomasterfrom
cleanup/stack-tooling-series
May 5, 2026
Merged

Simplify stack tooling and local CCC workflow#24
phroi merged 9 commits intomasterfrom
cleanup/stack-tooling-series

Conversation

@phroi
Copy link
Copy Markdown
Member

@phroi phroi commented May 5, 2026

Why

  • The stack repo had accumulated repo-local planning, publishing, and agent scaffolding that no longer matches the lightweight local workflow.
  • The current stack workflow depends on a materialized local CCC clone under forks/ccc/repo plus tracked pin state under forks/ccc/pin, so the scripts, docs, and CI path should reflect that contract directly.
  • The cleanup also needs a narrow local DAO output-limit wrapper because the current CCC types do not lint cleanly for direct ccc.assertDaoOutputLimit calls.

Changes

  • Drop obsolete stack-local scaffolding such as planning docs, changesets, typedoc config, and the old repo-local Claude/devcontainer surface.
  • Align package and app builds on tsc, keep apps/interface on tsc plus vite, and add explicit CCC override, build-surface, smoke, bootstrap, and tracked pin-state workflow support.
  • Clarify the local CCC workflow and SDK transaction-completion boundary in the docs and SDK tests.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modernizes the project's infrastructure by aligning with standard CCC patterns, removing custom abstractions like SmartTransaction and UdtHandler in favor of native CCC classes. It overhauls the fork management system using pnpm overrides and dedicated scripts, while also deleting extensive legacy planning and research documentation. New SDK unit tests are introduced, and the build process is updated to use tsc. Feedback points out a critical security risk in the forks:bootstrap script's use of curl | bash and suggests pinning the eslint-plugin-react-compiler dependency to improve build stability.

Comment thread package.json Outdated
Comment thread package.json Outdated
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 5, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a significant refactoring of the iCKB stack, primarily focusing on removing the deprecated SmartTransaction abstraction, migrating to CCC-native UDT handling, and cleaning up the codebase by removing legacy Lumos dependencies and local utility functions. The changes include deleting deprecated files, updating manager method signatures to use ccc.TransactionLike, and wiring the SDK to use the new IckbUdt implementation. My feedback highlights concerns regarding the removal of .pnpm-store/ from .gitignore, the pinning of the react-compiler version, the simplification of the Vite configuration, and the manual update of the pnpm-workspace.yaml catalog.

Comment thread .gitignore
Comment thread apps/interface/package.json
Comment thread apps/interface/vite.config.ts
Comment thread pnpm-workspace.yaml
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 5, 2026

/gemini review

@phroi phroi force-pushed the cleanup/stack-tooling-series branch from 1f3c237 to d6307bd Compare May 5, 2026 12:21
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the monorepo's build and fork management workflows, replacing custom build wrappers with standard TypeScript compilation and introducing a materialization process for local CCC forks. It also cleans up legacy planning documentation and adds utility scripts for environment bootstrapping and validation. Feedback suggests automating the generation of workspace overrides from the configuration source of truth to improve maintainability and reduce manual errors.

Comment thread pnpm-workspace.yaml
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 5, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase to remove the deprecated SmartTransaction class and its associated infrastructure, replacing it with native CCC transaction completion patterns. It also centralizes the NervosDAO 64-output limit check into a reusable CCC utility and updates all scattered inline checks to use this new utility. My feedback focuses on improving error handling by suggesting a custom error class for the DAO output limit check, which provides structured context to callers instead of a generic Error.

Comment thread packages/dao/src/dao.ts
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 5, 2026

/gemini review

@gemini-code-assist
Copy link
Copy Markdown

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.

@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 5, 2026

LGTM

Phroi %164

@phroi phroi merged commit d54dec0 into master May 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant