Skip to content

prelim(bot): start CCC migration#26

Merged
phroi merged 2 commits intomasterfrom
prelim/bot-ccc-migration
May 5, 2026
Merged

prelim(bot): start CCC migration#26
phroi merged 2 commits intomasterfrom
prelim/bot-ccc-migration

Conversation

@phroi
Copy link
Copy Markdown
Member

@phroi phroi commented May 5, 2026

Why

  • land the bot move off the legacy Lumos and v1 stack onto the current CCC-based workspace packages as preliminary migration work
  • fix the shared UDT-to-CKB matcher path the new bot flow now depends on

Changes

  • rewrite apps/bot around IckbSdk, OrderManager, LogicManager, and OwnedOwnerManager while keeping app-local signing, fee completion, send, and rebalance policy
  • add focused tests for the shared order matcher fix and the bot rebalance policy
  • update bot package metadata, README, and env fixtures to match the preliminary CCC-native runtime

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the iCKB bot to be CCC-native, replacing Lumos-based dependencies with the CCC framework and updating the README and package configuration accordingly. It introduces a new rebalancing policy and modularizes the state management and transaction building logic. A critical issue was identified in the cell collection logic where an incorrect filter configuration would prevent the bot from discovering capacity cells, potentially halting its operation.

Comment thread apps/bot/src/index.ts
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 5, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the iCKB bot to a CCC-native architecture, replacing Lumos dependencies with @ckb-ccc/core and internal @ickb packages. The bot's core logic in index.ts has been refactored to utilize the new SDK, and a new rebalancing policy has been implemented with unit tests. Additionally, a bug in the OrderMatcher was fixed where incorrect scale factors were used for UDT-to-CKB orders, and new checks for matchability and minimum match requirements were added. I have no feedback to provide.

@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 5, 2026

LGTM

Phroi %115

@phroi phroi merged commit a98807b into master May 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant