Skip to content

prelim(tester): migrate to CCC and drop faucet app#27

Merged
phroi merged 5 commits intomasterfrom
prelim/tester-ccc-faucet-cleanup
May 6, 2026
Merged

prelim(tester): migrate to CCC and drop faucet app#27
phroi merged 5 commits intomasterfrom
prelim/tester-ccc-faucet-cleanup

Conversation

@phroi
Copy link
Copy Markdown
Member

@phroi phroi commented May 5, 2026

Why

  • land this stack work as preliminary cleanup while the tester and faucet surfaces are still moving through the broader CCC migration sequence
  • remove the deleted faucet app's remaining stack fallout and restore local runtime behavior after the tester migration

Changes

  • rewrite apps/tester around the CCC runtime, shared iCKB workspace packages, and the existing bot-style transaction completion flow
  • remove the apps/faucet app, clean up stack-owned faucet references, and make stack scripts tolerate missing app manifests
  • update local workspace package exports so Node resolves @ickb/{utils,dao,core,order,sdk} to dist/ at runtime, and refresh docs/lockfile to match

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the faucet application and refactors the tester application to be CCC-native, replacing Lumos-based logic with the CCC framework and shared workspace packages. It also updates package exports to point to distribution files, refines workspace configurations for the CCC fork, and adds existence checks to dependency collection scripts. Feedback identifies potential precision loss in the tester's randomized decision and amount calculations where bigint values are converted to Number, suggesting the use of bigint arithmetic to ensure accuracy with large balances.

Comment thread apps/tester/src/index.ts Outdated
Comment thread apps/tester/src/index.ts
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 6, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the faucet application and refactors the tester application to be CCC-native, replacing previous Lumos dependencies with @ckb-ccc/core and internal workspace packages. The refactor involves a significant rewrite of the tester's core logic for state retrieval and transaction construction. Additionally, the PR updates the package exports for several workspace packages to point to compiled distribution files and refines the workspace configuration for local forks. Feedback on the tester implementation suggests optimizing cell collection by using API-side filters for pure-capacity cells to improve efficiency.

Comment thread apps/tester/src/index.ts Outdated
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 6, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the tester application to be CCC-native, replacing Lumos-based logic with the @ickb SDK and core packages. It also removes the faucet application, updates package exports to point to distribution files, and refines workspace configurations and scripts. Review feedback highlights the need to maintain consistent casing in log keys, remove redundant manual cell filters already covered by query parameters, and optimize performance by using available block number data instead of making repeated RPC calls in loops.

Comment thread apps/tester/src/index.ts
Comment thread apps/tester/src/index.ts Outdated
Comment thread apps/tester/src/index.ts
Comment thread apps/tester/src/index.ts Outdated
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 6, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the tester application from Lumos to the CCC framework, refactoring its core logic to use the new IckbSdk for state management and transaction building. It also removes the faucet application, updates workspace configurations, and ensures package exports point to compiled distribution files. Feedback focuses on correcting API usage for findCellsOnChain, optimizing order matching by removing redundant RPC calls that could cause crashes for mempool transactions, and improving efficiency by using synchronous fee calculations.

Comment thread apps/tester/src/index.ts
Comment thread apps/tester/src/index.ts
Comment thread apps/tester/src/index.ts
Comment thread apps/tester/src/index.ts
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 6, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the faucet application and refactors the tester application to be CCC-native, replacing Lumos dependencies with @ckb-ccc/core and internal workspace packages. It also updates package exports to point to distribution files, refines workspace configurations, and adds safety checks to maintenance scripts. Feedback highlights a TypeScript compilation error in the tester's error logging and suggests removing a redundant manual filter for UDT cells.

Comment thread apps/tester/src/index.ts
Comment thread apps/tester/src/index.ts
@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 6, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project to a CCC-native architecture, primarily by refactoring the tester application to use @ckb-ccc/core and the shared @ickb SDK and core packages, replacing the previous Lumos-based implementation. The faucet application has been entirely removed, and the interface documentation has been updated to reflect this change. Furthermore, package exports were updated to point to build distributions, and workspace configurations were refined to explicitly list included packages. I have no feedback to provide as there were no review comments.

@phroi
Copy link
Copy Markdown
Member Author

phroi commented May 6, 2026

LGTM

Phroi %94

@phroi phroi merged commit 58149f7 into master May 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant