prelim(tester): migrate to CCC and drop faucet app#27
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the faucet application and refactors the tester application to be CCC-native, replacing Lumos-based logic with the CCC framework and shared workspace packages. It also updates package exports to point to distribution files, refines workspace configurations for the CCC fork, and adds existence checks to dependency collection scripts. Feedback identifies potential precision loss in the tester's randomized decision and amount calculations where bigint values are converted to Number, suggesting the use of bigint arithmetic to ensure accuracy with large balances.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes the faucet application and refactors the tester application to be CCC-native, replacing previous Lumos dependencies with @ckb-ccc/core and internal workspace packages. The refactor involves a significant rewrite of the tester's core logic for state retrieval and transaction construction. Additionally, the PR updates the package exports for several workspace packages to point to compiled distribution files and refines the workspace configuration for local forks. Feedback on the tester implementation suggests optimizing cell collection by using API-side filters for pure-capacity cells to improve efficiency.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates the tester application to be CCC-native, replacing Lumos-based logic with the @ickb SDK and core packages. It also removes the faucet application, updates package exports to point to distribution files, and refines workspace configurations and scripts. Review feedback highlights the need to maintain consistent casing in log keys, remove redundant manual cell filters already covered by query parameters, and optimize performance by using available block number data instead of making repeated RPC calls in loops.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates the tester application from Lumos to the CCC framework, refactoring its core logic to use the new IckbSdk for state management and transaction building. It also removes the faucet application, updates workspace configurations, and ensures package exports point to compiled distribution files. Feedback focuses on correcting API usage for findCellsOnChain, optimizing order matching by removing redundant RPC calls that could cause crashes for mempool transactions, and improving efficiency by using synchronous fee calculations.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes the faucet application and refactors the tester application to be CCC-native, replacing Lumos dependencies with @ckb-ccc/core and internal workspace packages. It also updates package exports to point to distribution files, refines workspace configurations, and adds safety checks to maintenance scripts. Feedback highlights a TypeScript compilation error in the tester's error logging and suggests removing a redundant manual filter for UDT cells.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates the project to a CCC-native architecture, primarily by refactoring the tester application to use @ckb-ccc/core and the shared @ickb SDK and core packages, replacing the previous Lumos-based implementation. The faucet application has been entirely removed, and the interface documentation has been updated to reflect this change. Furthermore, package exports were updated to point to build distributions, and workspace configurations were refined to explicitly list included packages. I have no feedback to provide as there were no review comments.
|
LGTM Phroi %94 |
Why
Changes
apps/testeraround the CCC runtime, shared iCKB workspace packages, and the existing bot-style transaction completion flowapps/faucetapp, clean up stack-owned faucet references, and make stack scripts tolerate missing app manifests@ickb/{utils,dao,core,order,sdk}todist/at runtime, and refresh docs/lockfile to match